LGTM. Nice catch. One comment though.
https://codereview.chromium.org/12217136/diff/1/src/token.h
File src/token.h (right):
https://codereview.chromium.org/12217136/diff/1/src/token.h#newcode239
src/token.h:239: return op;
Same argumentation as below applies.
https://codereview.chromium.org/12217136/diff/1/src/token.h#newcode255
src/token.h:255: return op;
The "IN" and the "INSTANCEOF" operation cannot really be inverted I
think. So calling InvertCompareOp() on them would point to a bug I
guess. Can we hence change the default branch to assert that it's
UNREACHABLE()?
https://codereview.chromium.org/12217136/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
