LGTM if the comments are addresses. I commented on ia32 but the comments
hold
for arm and x64 too.
https://chromiumcodereview.appspot.com/12210143/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://chromiumcodereview.appspot.com/12210143/diff/1/src/ia32/code-stubs-ia32.cc#newcode3895
src/ia32/code-stubs-ia32.cc:3895: // (4) Cons string. Replace subject
with first string.
"(4) Cons string. If the string is flat ..., otherwise bailout."
https://chromiumcodereview.appspot.com/12210143/diff/1/src/ia32/code-stubs-ia32.cc#newcode3896
src/ia32/code-stubs-ia32.cc:3896: // (5a) Is subject two byte? If yes,
go to (9).
"Is subject sequential two byte"
https://chromiumcodereview.appspot.com/12210143/diff/1/src/ia32/code-stubs-ia32.cc#newcode3949
src/ia32/code-stubs-ia32.cc:3949: // (5a) Is subject two byte? If yes,
go to (9).
Is subject sequential two byte
https://chromiumcodereview.appspot.com/12210143/diff/1/src/ia32/code-stubs-ia32.cc#newcode4163
src/ia32/code-stubs-ia32.cc:4163: ecx,
__ mov(eax, ecx) would allow to use the existing write barrier stub.
https://chromiumcodereview.appspot.com/12210143/diff/1/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://chromiumcodereview.appspot.com/12210143/diff/1/src/x64/macro-assembler-x64.cc#newcode477
src/x64/macro-assembler-x64.cc:477: int3();
Leftover debug code?
https://chromiumcodereview.appspot.com/12210143/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
