Reviewers: Yury Semikhatsky, Yang,
Description:
Heap snapshot doesn't detect the fact that an old object was overriden by
new
one.
It is a test only patch. I have no solution yet.
BUG=V8:2189
TEST=
Please review this at https://chromiumcodereview.appspot.com/12321042/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/test-heap-profiler.cc
Index: test/cctest/test-heap-profiler.cc
diff --git a/test/cctest/test-heap-profiler.cc
b/test/cctest/test-heap-profiler.cc
index
a8a45b7b69e6c5ab458123dc0fa71946c8c772ba..49586be15bd93c6329c75ac86a66335dbb392c6f
100644
--- a/test/cctest/test-heap-profiler.cc
+++ b/test/cctest/test-heap-profiler.cc
@@ -360,6 +360,45 @@ TEST(HeapSnapshotInternalReferences) {
#define CHECK_NE_SNAPSHOT_OBJECT_ID(a, b) \
CHECK((a) != (b)) // NOLINT
+TEST(HeapSnapshotAddressReuse) {
+ v8::HandleScope scope;
+ LocalContext env;
+
+ CompileRun(
+ "function A() {}\n"
+ "var a = [];\n"
+ "for (var i = 0; i < 10000; ++i)\n"
+ " a[i] = new A();\n");
+ const v8::HeapSnapshot* snapshot1 =
+ v8::HeapProfiler::TakeSnapshot(v8_str("snapshot1"));
+ v8::SnapshotObjectId maxId1 = snapshot1->GetMaxSnapshotJSObjectId();
+
+ CompileRun(
+ "for (var i = 0; i < 10000; ++i)\n"
+ " a[i] = new A();\n");
+ HEAP->CollectAllGarbage(i::Heap::kNoGCFlags);
+
+ const v8::HeapSnapshot* snapshot2 =
+ v8::HeapProfiler::TakeSnapshot(v8_str("snapshot2"));
+ const v8::HeapGraphNode* global2 = GetGlobalObject(snapshot2);
+
+ const v8::HeapGraphNode* array_node =
+ GetProperty(global2, v8::HeapGraphEdge::kProperty, "a");
+ CHECK_NE(NULL, array_node);
+ int wrong_count = 0;
+ for (int i = 0, count = array_node->GetChildrenCount(); i < count; ++i) {
+ const v8::HeapGraphEdge* prop = array_node->GetChild(i);
+ if (prop->GetType() != v8::HeapGraphEdge::kElement)
+ continue;
+ v8::SnapshotObjectId id = prop->GetToNode()->GetId();
+ if (id < maxId1)
+ ++wrong_count;
+ }
+ // FIXME: We have problem with address reuse.
+ CHECK_NE(0, wrong_count);
+}
+
+
TEST(HeapEntryIdsAndArrayShift) {
v8::HandleScope scope;
LocalContext env;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
