Apart from some last nits, lgtm.
https://codereview.chromium.org/11818021/diff/34001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/11818021/diff/34001/src/objects.h#newcode6986
src/objects.h:6986:
... remove.
On 2013/02/13 15:14:51, Toon Verwaest wrote:
Remove.
https://codereview.chromium.org/11818021/diff/52004/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/11818021/diff/52004/src/heap.cc#newcode4255
src/heap.cc:4255: // mode = DONT_TRACK_ALLOCATION_SITE;
Use GetMode(to_kind); here to decide whether or not to track
ALLOCATION_SITE.
https://codereview.chromium.org/11818021/diff/52004/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/11818021/diff/52004/src/objects.cc#newcode10037
src/objects.cc:10037: if (trans->IsFailure()) return trans;
MaybeObject* maybe_failure = ...;
if (maybe_failure->IsFailure()) return maybe_failure;
https://codereview.chromium.org/11818021/diff/52004/src/objects.cc#newcode10053
src/objects.cc:10053: MaybeObject* trans =
UpdateAllocationSiteInfo(kind);
MaybeObject* maybe_failure = ...;
if (maybe_failure->IsFailure()) return maybe_failure;
https://codereview.chromium.org/11818021/diff/52004/src/objects.cc#newcode10603
src/objects.cc:10603: return NULL;
return this;
https://codereview.chromium.org/11818021/diff/52004/src/objects.cc#newcode10608
src/objects.cc:10608: return NULL;
return this;
https://codereview.chromium.org/11818021/diff/52004/src/objects.cc#newcode10662
src/objects.cc:10662: if (trans->IsFailure()) return trans;
MaybeObject* maybe_failure = ...;
if (maybe_failure->IsFailure()) return maybe_failure;
https://codereview.chromium.org/11818021/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
