On 2013/02/26 16:47:15, adamk wrote:
[resending to capture this on the codereview]
The call sequence is:
JSReceiver::HasElement
JSObject::GetElementAttributeWithReceiver
JSObject::GetElementAttributeWithoutInterceptor
GetElementAttributeWithoutInterceptor() does two things:
1. Check if the index is present in the element backing store
2. If not, check if this is a string object with a character at that index
The call sequence for "'0' in o" is:
JSReceiver::HasProperty
JSObject::GetPropertyAttribute
JSObject::GetPropertyAttributeWithReceiver
JSObject::GetElementAttributeWithReceiver
JSObject::GetElementAttributeWithoutInterceptor
I think I shot myself in the foot here by removing the HandleScope from
GetElementAttributeWithoutInterceptor in the same change, which obscures
the
fact that its call to IsStringObjectWithCharacterAt remains unchanged.
Oh. You are right, I _was_ confused. :) In that case, LGTM
https://codereview.chromium.org/12328064/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
