Sorry for the long delay. Almost looking good.
https://codereview.chromium.org/12184016/diff/8001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/12184016/diff/8001/src/mark-compact.cc#newcode526
src/mark-compact.cc:526:
heap()->paged_space(OLD_POINTER_SPACE)->ResetUnsweptFreeBytes();
This requires rebasing, but I agree that WaitUntilSweepingCompleted() is
the right place for the reset.
https://codereview.chromium.org/12184016/diff/8001/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/12184016/diff/8001/src/spaces.h#newcode1754
src/spaces.h:1754: void DecreaseUnsweptFreeBytes(int by) {
Let's rename this to DecrementUnsweptFreeBytes() which is in line with
the other names.
https://codereview.chromium.org/12184016/diff/8001/src/sweeper-thread.cc
File src/sweeper-thread.cc (right):
https://codereview.chromium.org/12184016/diff/8001/src/sweeper-thread.cc#newcode82
src/sweeper-thread.cc:82: space->DecreaseUnsweptFreeBytes(free_bytes);
As discussed offline: Let's move both (AddToAccountingStats and
DecreaseUnsweptFreeBytes) into
MarkCompactCollector::StealMemoryFromSweeperThreads, it should be part
the mark-compact.cc file.
https://codereview.chromium.org/12184016/diff/8001/src/sweeper-thread.h
File src/sweeper-thread.h (right):
https://codereview.chromium.org/12184016/diff/8001/src/sweeper-thread.h#newcode65
src/sweeper-thread.h:65: intptr_t StealMemory(PagedSpace* space,
FreeList* free_list);
This declaration is obsolete after addressing the comment in the
sweeper-thread.cc file.
https://codereview.chromium.org/12184016/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
