Reviewers: Michael Starzinger,
Description:
Also fix cast warnings on Win64
[email protected]
BUG=
Please review this at https://codereview.chromium.org/12398011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/x64/code-stubs-x64.cc
M src/x64/macro-assembler-x64.cc
Index: src/x64/code-stubs-x64.cc
diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc
index
83fc246d6b34e51c2a6423018cc10dccc67d9bf1..e2ca0718f65f11ff6475c8980c9059714311c640
100644
--- a/src/x64/code-stubs-x64.cc
+++ b/src/x64/code-stubs-x64.cc
@@ -6261,7 +6261,7 @@ void
NameDictionaryLookupStub::GenerateNegativeLookup(MacroAssembler* masm,
Immediate(kIsInternalizedMask));
__ j(not_zero, &good, Label::kNear);
__ cmpb(FieldOperand(entity_name, Map::kInstanceTypeOffset),
- Immediate(static_cast<int8_t>(SYMBOL_TYPE)));
+ Immediate(static_cast<uint8_t>(SYMBOL_TYPE)));
__ j(not_equal, miss);
__ bind(&good);
@@ -6395,7 +6395,7 @@ void
NameDictionaryLookupStub::Generate(MacroAssembler* masm) {
Immediate(kIsInternalizedMask));
__ j(not_zero, &cont);
__ cmpb(FieldOperand(scratch, Map::kInstanceTypeOffset),
- Immediate(static_cast<int8_t>(SYMBOL_TYPE)));
+ Immediate(static_cast<uint8_t>(SYMBOL_TYPE)));
__ j(not_equal, &maybe_in_dictionary);
__ bind(&cont);
}
Index: src/x64/macro-assembler-x64.cc
diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc
index
24777e8a7e1afebc59d50269f33957a5bb39cb41..22a7046196ca4476d2136e603c20e34d52e82537
100644
--- a/src/x64/macro-assembler-x64.cc
+++ b/src/x64/macro-assembler-x64.cc
@@ -3059,7 +3059,7 @@ Condition MacroAssembler::IsObjectNameType(Register
heap_object,
Register instance_type) {
movq(map, FieldOperand(heap_object, HeapObject::kMapOffset));
movzxbl(instance_type, FieldOperand(map, Map::kInstanceTypeOffset));
- cmpb(instance_type, Immediate(static_cast<int8_t>(LAST_NAME_TYPE)));
+ cmpb(instance_type, Immediate(static_cast<uint8_t>(LAST_NAME_TYPE)));
return below_equal;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
