Reviewers: Hannes Payer,
Description:
Enable zapping of disposed global handles in release mode.
[email protected]
BUG=chromium:176056
Please review this at https://codereview.chromium.org/12388080/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/global-handles.cc
Index: src/global-handles.cc
diff --git a/src/global-handles.cc b/src/global-handles.cc
index
299449a34e37edc426ee884e0004452245ef029e..a6347bbf8afbd9743a2861bfef424170a8324ad8
100644
--- a/src/global-handles.cc
+++ b/src/global-handles.cc
@@ -113,10 +113,10 @@ class GlobalHandles::Node {
void Release(GlobalHandles* global_handles) {
ASSERT(state() != FREE);
set_state(FREE);
- // TODO(176056): Enable as soon as WebKit bindings are fixed.
-#ifdef DEBUG_TODO
- // Zap the values for eager trapping.
+ // TODO(mstarzinger): Put behind debug flag once embedders are
stabilized.
object_ = reinterpret_cast<Object*>(kGlobalHandleZapValue);
+#ifdef DEBUG
+ // Zap the values for eager trapping.
class_id_ = v8::HeapProfiler::kPersistentHandleNoClassId;
set_independent(false);
set_partially_dependent(false);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
