LGTM, nits only.
https://codereview.chromium.org/12391055/diff/46/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/12391055/diff/46/src/assembler.cc#newcode184
src/assembler.cc:184: // Implementation of PredictableCodeSizeScope
Comment should say s/PredictableCodeSizeScope/CpuFeatureScope/ here.
https://codereview.chromium.org/12391055/diff/46/src/ia32/assembler-ia32.cc
File src/ia32/assembler-ia32.cc (right):
https://codereview.chromium.org/12391055/diff/46/src/ia32/assembler-ia32.cc#newcode149
src/ia32/assembler-ia32.cc:149: {CpuFeatureScope fscope(&assm, CPUID);
White-space after the opening brace.
https://codereview.chromium.org/12391055/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
