LGTM with comments.
https://codereview.chromium.org/12390057/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/12390057/diff/1/src/api.cc#newcode3919
src/api.cc:3919: if (EndsWithSurrogate(leaf_state)) {
something to consider here:
http://graphics.stanford.edu/~seander/bithacks.html#ConditionalSetOrClearBitsWithoutBranching
https://codereview.chromium.org/12390057/diff/1/src/api.cc#newcode4112
src/api.cc:4112: if (sizeof(Char) == 1) {
It looks like this if should be hoisted to outside the for-loop.
https://codereview.chromium.org/12390057/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
