LGTM with a real comment and a nit.
https://chromiumcodereview.appspot.com/12451003/diff/8016/src/ic.cc
File src/ic.cc (right):
https://chromiumcodereview.appspot.com/12451003/diff/8016/src/ic.cc#newcode1041
src/ic.cc:1041: AssertNoAllocation no_gc;
This AssertNoAllocation (and its scope) seem unnecessary, since you have
one on line 1035 too.
https://chromiumcodereview.appspot.com/12451003/diff/8016/src/stub-cache.cc
File src/stub-cache.cc (right):
https://chromiumcodereview.appspot.com/12451003/diff/8016/src/stub-cache.cc#newcode907
src/stub-cache.cc:907: Code::StubType type = handlers->length() == 1
nit: I have a weak preference for the following formatting, but you can
also keep what you have if you prefer:
Code::StubType type = handlers->length() == 1 ?
handlers->at(0)->type()
: Code::NORMAL;
https://chromiumcodereview.appspot.com/12451003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
