addressed comments
https://chromiumcodereview.appspot.com/12389077/diff/1/tools/grokdump.py
File tools/grokdump.py (right):
https://chromiumcodereview.appspot.com/12389077/diff/1/tools/grokdump.py#newcode1467
tools/grokdump.py:1467: print "[%i] details: %s %s enum %i pointer %i" %
self.Details(di, array.Get(i + 1))
On 2013/03/05 16:14:57, Michael Starzinger wrote:
Longer than 80 characters.
Done.
https://chromiumcodereview.appspot.com/12389077/diff/1/tools/grokdump.py#newcode2010
tools/grokdump.py:2010: def do_desc(self, address):
On 2013/03/05 16:14:57, Michael Starzinger wrote:
Can we rename these commands to have a common prefix? For exmaple
"do_desc",
"do_trans" and "do_map" (where "do" mean "dump object"). That would be
in line
with the "do" command we already have. Also can we then alpha-sort the
commands?
Done.
https://chromiumcodereview.appspot.com/12389077/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
