LGTM with comments
https://codereview.chromium.org/13158002/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/13158002/diff/1/src/heap.cc#newcode5434
src/heap.cc:5434: AllocationSpace space = OLD_POINTER_SPACE;
Nit: just inline this now trivial definition.
https://codereview.chromium.org/13158002/diff/1/test/mjsunit/harmony/symbols.js
File test/mjsunit/harmony/symbols.js (right):
https://codereview.chromium.org/13158002/diff/1/test/mjsunit/harmony/symbols.js#newcode306
test/mjsunit/harmony/symbols.js:306: var key = Symbol("key");
Please wrap this into a Test function with a descriptive name (and
perhaps a comment, because the purpose of the test isn't all that
obvious).
https://codereview.chromium.org/13158002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
