https://codereview.chromium.org/12491023/diff/5001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/12491023/diff/5001/src/hydrogen-instructions.h#newcode5171
src/hydrogen-instructions.h:5171:
result->SetGVNFlag(kDependsOnArrayLengths);
Clear the flag for kDependsOnInobjectFields, might require a slight bit
of restructuring.
https://codereview.chromium.org/12491023/diff/5001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/12491023/diff/5001/src/hydrogen.cc#newcode1169
src/hydrogen.cc:1169: HLoadNamedField::NewArrayLength(zone, object,
mapcheck));
I think you are losing the fact that the type of this instruction is a
Smi. It is used for optimization purposes later in the compilation
pipeline. Some array lengths are known to be Smis (if their map is
guaranteed to fast elements), but otherwise, they may be a tagged heap
number, which will require more heavy checks in the generated code. You
will need to preserve the ability to specify the return type of the
load.
https://codereview.chromium.org/12491023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
