Revision: 14162
Author: [email protected]
Date: Mon Apr 8 04:53:50 2013
Log: Devirtualize Parser
* src/parser.h: No one inherits from Parser, so the destructor can be
non-virtual, removing the need for Parser to have a vtable. Also add
BASE_EMBEDDED to it and to RegExpParser.
BUG=
Review URL: https://codereview.chromium.org/13640007
Patch from Andy Wingo <[email protected]>.
http://code.google.com/p/v8/source/detail?r=14162
Modified:
/branches/bleeding_edge/src/parser.h
=======================================
--- /branches/bleeding_edge/src/parser.h Fri Apr 5 06:01:06 2013
+++ /branches/bleeding_edge/src/parser.h Mon Apr 8 04:53:50 2013
@@ -293,7 +293,7 @@
};
-class RegExpParser {
+class RegExpParser BASE_EMBEDDED {
public:
RegExpParser(FlatStringReader* in,
Handle<String>* error,
@@ -423,10 +423,10 @@
// Forward declaration.
class SingletonLogger;
-class Parser {
+class Parser BASE_EMBEDDED {
public:
explicit Parser(CompilationInfo* info);
- virtual ~Parser() {
+ ~Parser() {
delete reusable_preparser_;
reusable_preparser_ = NULL;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
