https://codereview.chromium.org/13626002/diff/3001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/13626002/diff/3001/include/v8.h#newcode1481
include/v8.h:1481: static Local<Symbol> New();
On 2013/04/08 14:04:51, Sven Panne wrote:
Add an Isolate* parameter.
Done.
https://codereview.chromium.org/13626002/diff/3001/include/v8.h#newcode1484
include/v8.h:1484: static Local<Symbol> New(const char* data, int length
= -1);
On 2013/04/08 14:04:51, Sven Panne wrote:
Add an Isolate* parameter.
Done.
https://codereview.chromium.org/13626002/diff/3001/include/v8.h#newcode1634
include/v8.h:1634: // TODO(1245389): Replace the type-specific versions
of these
On 2013/04/08 14:04:51, Sven Panne wrote:
Does this TODO still make sense?
No, deleted.
https://codereview.chromium.org/13626002/diff/3001/include/v8.h#newcode2032
include/v8.h:2032: static Local<Value> New(Handle<Symbol> value);
On 2013/04/08 14:04:51, Sven Panne wrote:
Add an Isolate* parameter.
Done.
https://codereview.chromium.org/13626002/diff/3001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/13626002/diff/3001/src/api.cc#newcode2464
src/api.cc:2464: return
obj->HasSpecificClassOf(isolate->heap()->Symbol_string());
On 2013/04/08 14:04:51, Sven Panne wrote:
Can we somehow make this test without the Isolate::Current()? The
point is that
the IsDeadChecks will die soon, and we shouldn't rely on the current
Isolate.
As discussed offline, keeping it like this for now for consistency with
other test functions. Needs more general clean-up.
https://codereview.chromium.org/13626002/diff/3001/src/api.cc#newcode2741
src/api.cc:2741:
ApiCheck(obj->HasSpecificClassOf(isolate->heap()->Symbol_string()),
On 2013/04/08 14:04:51, Sven Panne wrote:
Same comment as for IsSymbolObject.
Same here.
https://codereview.chromium.org/13626002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
