https://codereview.chromium.org/13483017/diff/1/test/cctest/cctest.h
File test/cctest/cctest.h (right):
https://codereview.chromium.org/13483017/diff/1/test/cctest/cctest.h#newcode67
test/cctest/cctest.h:67: enum CcTestExtensionFlags {
On 2013/04/09 07:26:28, Sven Panne wrote:
Using EnumSet here would be simpler and actually more readable. This
avoids our
common confusion between an element and a set of elements on the type
level.
Using "CcExtensionFlag" is a more appropriate then, too.
Done.
https://codereview.chromium.org/13483017/diff/1/test/cctest/cctest.h#newcode94
test/cctest/cctest.h:94: static void InitializeVM(int extensions =
NO_EXTENSIONS);
On 2013/04/09 07:26:28, Sven Panne wrote:
Use EnumSet<CcTestExtensionFlag> (or perhaps a typedef of it) as a
parameter.
Done.
https://codereview.chromium.org/13483017/diff/1/test/cctest/test-assembler-mips.cc
File test/cctest/test-assembler-mips.cc (right):
https://codereview.chromium.org/13483017/diff/1/test/cctest/test-assembler-mips.cc#newcode47
test/cctest/test-assembler-mips.cc:47: #define __ assm.
On 2013/04/09 07:26:28, Sven Panne wrote:
If it is really OK to remove the FLAG_disable_native_files line here,
we should
probably nuke this flag.
I am not sure if it is really OK, I removed it and tests run through, so
I assumed it's a leftover from the original ports when MIPS couldn't
compile the builtins yet. As for removing the flag, I think it's better
to leave it in for other ports.
https://codereview.chromium.org/13483017/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
