Comments addressed. I still need to adapt test cases and will do so after
rebasing on the following dependent CL.
https://codereview.chromium.org/13483017/
https://codereview.chromium.org/13799003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/13799003/diff/1/include/v8.h#newcode3891
include/v8.h:3891: /** Deprecated. Use Isolate version instead. */
On 2013/04/09 07:08:33, Sven Panne wrote:
Perhaps add an explicit TODO for inserting V8_DEPRECATED, we have this
already
at other places.
Done.
https://codereview.chromium.org/13799003/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/13799003/diff/1/src/bootstrapper.cc#newcode308
src/bootstrapper.cc:308: if (InstallExtensions(env, extensions)) {
On 2013/04/09 07:08:33, Sven Panne wrote:
Merge the "if"s, move the last "return" to an "else" branch, swap the
"if"
branches by inverting the condition, drop the "else" again. :-) This
makes the
normal control flow clearer, with the exceptional cases bailing out
early, which
is a good idea:
http://www.refactoring.com/catalog/replaceNestedConditionalWithGuardClauses.html
Done.
https://codereview.chromium.org/13799003/diff/1/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/13799003/diff/1/src/debug.cc#newcode878
src/debug.cc:878: debug_context_ = Handle<Context>::cast(
On 2013/04/09 07:08:33, Sven Panne wrote:
I don't fully understand why this is necessary...
As discussed offline, this creates a persistent handle for the newly
created debug context so that it can be put into a static (per-isolate)
variable.
https://codereview.chromium.org/13799003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
