Additionally, I did minor cleanup changes.
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode6200
src/hydrogen.cc:6200: new(zone()) HObjectLiteral(context,
On 2013/04/09 08:52:42, danno wrote:
nit: strange indenting?
Done.
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode10200
src/hydrogen.cc:10200: HInstruction* boilerplate_elements =
On 2013/04/09 08:52:42, danno wrote:
From here....
Done.
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode10208
src/hydrogen.cc:10208: true, JSObject::kElementsOffset));
On 2013/04/09 08:52:42, danno wrote:
... til here is not needed.
This is a FixedArray, it doesn't have a elements()
Done.
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode10210
src/hydrogen.cc:10210:
On 2013/04/09 08:52:42, danno wrote:
ASSERT(kFixedArrayHeaderSize = 2 * kPointer);
What do you want to check but that assert?
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode10212
src/hydrogen.cc:10212: AddInstruction(new(zone)
HFixedArrayBaseLength(boilerplate_elements));
On 2013/04/09 08:52:42, danno wrote:
You can replace this with a constant load, too.
Done.
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode10279
src/hydrogen.cc:10279: HInstruction* value_instruction;
On 2013/04/09 08:52:42, danno wrote:
Maybe different names? elements?
Done.
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode10284
src/hydrogen.cc:10284: header_field, Representation::None()));
On 2013/04/09 08:52:42, danno wrote:
Tagged
Done.
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode10290
src/hydrogen.cc:10290: factory->empty_string(),
On 2013/04/09 08:52:42, danno wrote:
nit: indent
Done.
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode10293
src/hydrogen.cc:10293: AddSimulate(id);
On 2013/04/09 08:52:42, danno wrote:
Make sure to set the kChangesElementsPointer GVN flag here
Done.
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode10296
src/hydrogen.cc:10296: value_instruction = AddInstruction(new(zone)
HConstant(
On 2013/04/09 08:52:42, danno wrote:
properties
Done.
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode10301
src/hydrogen.cc:10301: true, JSObject::kPropertiesOffset));
On 2013/04/09 08:52:42, danno wrote:
As discussed, perhaps you only want to do this in the cow case? The
allocation
of the elements might better belong next to the code above the
initializes the
elements header and then copies the elements.
This belongs to elements. Done.
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode10312
src/hydrogen.cc:10312: factory->empty_string(),
On 2013/04/09 08:52:42, danno wrote:
length_field_string
Done.
https://codereview.chromium.org/12880017/diff/7001/src/hydrogen.cc#newcode10314
src/hydrogen.cc:10314: true, JSArray::kLengthOffset));
On 2013/04/09 08:52:42, danno wrote:
Make sure to set the kChangesArrayLengths GVN flag here.
Done.
https://codereview.chromium.org/12880017/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
