Reviewers: Jakob,
Message:
ptal
Description:
Run style checks also when uploading.
The right moment for fixing style errors is when working on the CL, not when
committing it. And this makes non-committers bump into this check too when
uploading changes.
Patch by [email protected].
BUG=none
Please review this at https://codereview.chromium.org/14070005/
SVN Base: git://github.com/v8/v8.git@master
Affected files:
M PRESUBMIT.py
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index
0077be941a00f77d92f1571c12c899e441d3e22b..7d6620384581651d703a2be36038b001c61a9a6d
100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -53,6 +53,7 @@ def _CommonChecks(input_api, output_api):
results = []
results.extend(input_api.canned_checks.CheckOwners(
input_api, output_api, source_file_filter=None))
+ results.extend(_V8PresubmitChecks(input_api, output_api))
return results
@@ -67,5 +68,4 @@ def CheckChangeOnCommit(input_api, output_api):
results.extend(_CommonChecks(input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasDescription(
input_api, output_api))
- results.extend(_V8PresubmitChecks(input_api, output_api))
return results
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
