https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2265
src/spaces.cc:2265: if (node != NULL) return node;
Missing statistical book-keeping about available_in_huge_free_list here.
https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2269
src/spaces.cc:2269: if (node != NULL) return node;
Missing statistical book-keeping about available_in_large_free_list
here.
https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2274
src/spaces.cc:2274: if (node != NULL) return node;
Missing statistical book-keeping about available_in_medium_free_list
here.
https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2283
src/spaces.cc:2283: Page* page = NULL;
nit: Move the declaration of "page" down into the conditionals where
it's actually used. Local code FTW.
https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2312
src/spaces.cc:2312: return FindNodeInHugeList(size_in_bytes, node_size);
Missing statistical book-keeping about available_in_huge_free_list here.
https://codereview.chromium.org/14208005/diff/3001/src/spaces.cc#newcode2319
src/spaces.cc:2319:
nit: Add second empty newline.
https://codereview.chromium.org/14208005/diff/3001/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/14208005/diff/3001/src/spaces.h#newcode1576
src/spaces.h:1576: // and it ignores the smalles category.
nit: s/smalles/smallest/
https://codereview.chromium.org/14208005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
