Reviewers: ulan,
Description:
Fix ARM specific GYP variables
Please review this at https://codereview.chromium.org/14208011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M Makefile
M build/common.gypi
M src/arm/constants-arm.h
Index: Makefile
diff --git a/Makefile b/Makefile
index
bedf087ceadc2286a65f8d8b563916918e1e90b2..f885bf14a7e40e431dc537140443cc4290dcf37f
100644
--- a/Makefile
+++ b/Makefile
@@ -179,8 +179,6 @@ endif
# When using the simulator, this flag is implied.
ifeq ($(armtest), on)
GYPFLAGS += -Darm_test=on
-else
- GYPFLAGS += -Darm_test=off
endif
# ----------------- available targets: --------------------
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
37cfe16aae66730d8c7ae2067fdcccfb39ce73ed..6dc9a7b6188cbc37e25ff07f697e39d600325ee7
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -44,30 +44,17 @@
# access is allowed for all CPUs.
'v8_can_use_unaligned_accesses%': 'default',
- # Setting 'v8_can_use_vfp2_instructions' to 'true' will enable use of
ARM VFP
- # instructions in the V8 generated code. VFP instructions will be
enabled
- # both for the snapshot and for the ARM target. Leaving the default
value
- # of 'false' will avoid VFP instructions in the snapshot and use CPU
feature
- # probing when running on the target.
- 'v8_can_use_vfp2_instructions%': 'false',
- 'v8_can_use_vfp3_instructions%': 'false',
-
# Setting 'v8_can_use_vfp32dregs' to 'true' will cause V8 to use the
VFP
# registers d16-d31 in the generated code, both in the snapshot and
for the
# ARM target. Leaving the default value of 'false' will avoid the use
of
# these registers in the snapshot and use CPU feature probing when
running
# on the target.
'v8_can_use_vfp32dregs%': 'false',
+ 'arm_test%': 'off',
# Similar to vfp but on MIPS.
'v8_can_use_fpu_instructions%': 'true',
- # Setting v8_use_arm_eabi_hardfloat to true will turn on V8 support
for ARM
- # EABI calling convention where double arguments are passed in VFP
- # registers. Note that the GCC flag '-mfloat-abi=hard' should be used
as
- # well when compiling for the ARM target.
- 'v8_use_arm_eabi_hardfloat%': 'false',
-
# Similar to the ARM hard float ABI but on MIPS.
'v8_use_mips_abi_hardfloat%': 'true',
Index: src/arm/constants-arm.h
diff --git a/src/arm/constants-arm.h b/src/arm/constants-arm.h
index
ffedfd1f26641e5080a49595c5a736975994bbe7..747dc5627a708de6d9d7a8ca6d8611f83280044f
100644
--- a/src/arm/constants-arm.h
+++ b/src/arm/constants-arm.h
@@ -44,8 +44,10 @@
defined(__ARM_ARCH_7R__) || \
defined(__ARM_ARCH_7__)
# define CAN_USE_ARMV7_INSTRUCTIONS 1
+#ifndef CAN_USE_VFP3_INSTRUCTIONS
# define CAN_USE_VFP3_INSTRUCTIONS
#endif
+#endif
#if defined(__ARM_ARCH_6__) || \
defined(__ARM_ARCH_6J__) || \
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
