LGTM with two nits. Thanks for looking into this!
https://codereview.chromium.org/14053008/diff/1004/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/14053008/diff/1004/src/x64/code-stubs-x64.cc#newcode4309
src/x64/code-stubs-x64.cc:4309: __ subq(rsp,
Immediate(kCalleeSaveXMMRegisters * kFullXMMRegisterSize);
nit: Indentation of the whole block is off.
https://codereview.chromium.org/14053008/diff/1004/src/x64/code-stubs-x64.cc#newcode4411
src/x64/code-stubs-x64.cc:4411: // On Win64 XMM6-XMM15 are callee-save
nit: Indentation of the comment is off.
https://codereview.chromium.org/14053008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
