Reviewers: Jakob,
Description:
Unify canonicalization of HAdd/HSub/HMul a bit.
HDiv/HMul are a slightly different story and will be handled in a separate
CL.
Please review this at https://codereview.chromium.org/14296013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
M src/hydrogen-instructions.cc
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index
0aabfbc43229198f181ec9f76d4aaf4724228f4f..89b739fee61e14cd28fa2724de49f193ad4537fa
100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -1422,21 +1422,14 @@ HValue* HBitNot::Canonicalize() {
}
-HValue* HAdd::Canonicalize() {
- if (!representation().IsInteger32()) return this;
- if (CheckUsesForFlag(kTruncatingToInt32)) ClearFlag(kCanOverflow);
- return this;
-}
-
-
-HValue* HSub::Canonicalize() {
- if (!representation().IsInteger32()) return this;
- if (CheckUsesForFlag(kTruncatingToInt32)) ClearFlag(kCanOverflow);
+HValue* HArithmeticBinaryOperation::Canonicalize() {
+ if (representation().IsInteger32() &&
CheckUsesForFlag(kTruncatingToInt32)) {
+ ClearFlag(kCanOverflow);
+ }
return this;
}
-// TODO(svenpanne) Use this in other Canonicalize() functions.
static bool IsIdentityOperation(HValue* arg1, HValue* arg2, int32_t
identity) {
return arg1->representation().IsSpecialization() &&
arg2->IsInteger32Constant() &&
@@ -1444,9 +1437,25 @@ static bool IsIdentityOperation(HValue* arg1,
HValue* arg2, int32_t identity) {
}
+HValue* HAdd::Canonicalize() {
+ if (IsIdentityOperation(left(), right(), 0)) return left();
+ if (IsIdentityOperation(right(), left(), 0)) return right();
+ HArithmeticBinaryOperation::Canonicalize();
+ return this;
+}
+
+
+HValue* HSub::Canonicalize() {
+ if (IsIdentityOperation(left(), right(), 0)) return left();
+ HArithmeticBinaryOperation::Canonicalize();
+ return this;
+}
+
+
HValue* HMul::Canonicalize() {
if (IsIdentityOperation(left(), right(), 1)) return left();
if (IsIdentityOperation(right(), left(), 1)) return right();
+ HArithmeticBinaryOperation::Canonicalize();
return this;
}
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index
e74de4a1b1dc345398aff5b765de113fd865f78d..54f06724029ee2ded35423c5889e8e48fb371724
100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -3842,6 +3842,8 @@ class HArithmeticBinaryOperation: public
HBinaryOperation {
: representation();
}
+ virtual HValue* Canonicalize();
+
private:
virtual bool IsDeletable() const { return true; }
};
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
