Feedback addressed, landing...
https://codereview.chromium.org/14296013/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/14296013/diff/1/src/hydrogen-instructions.cc#newcode1444
src/hydrogen-instructions.cc:1444: return this;
On 2013/04/18 09:11:06, Jakob wrote:
Instead of:
HArithmeticBinaryOperation::Canonicalize();
return this;
I would prefer:
return HArithmeticBinaryOperation::Canonicalize();
Otherwise that could lead to surprising behavior when someone puts
more logic
into the superclass function and doesn't notice that callers ignore
the return
value.
Good point, I even think I had something similar in previous versions.
:-/ Changed here and in HSub/HMul.
https://codereview.chromium.org/14296013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
