Revision: 14324
Author: [email protected]
Date: Thu Apr 18 02:53:49 2013
Log: Improve generated code for HDoCompareObjectEqAndBranch on ia32/x64
[email protected]
Review URL: https://codereview.chromium.org/14083008
http://code.google.com/p/v8/source/detail?r=14324
Modified:
/branches/bleeding_edge/src/ia32/lithium-codegen-ia32.cc
/branches/bleeding_edge/src/ia32/lithium-ia32.cc
/branches/bleeding_edge/src/x64/lithium-codegen-x64.cc
/branches/bleeding_edge/src/x64/lithium-x64.cc
=======================================
--- /branches/bleeding_edge/src/ia32/lithium-codegen-ia32.cc Tue Apr 16
05:30:51 2013
+++ /branches/bleeding_edge/src/ia32/lithium-codegen-ia32.cc Thu Apr 18
02:53:49 2013
@@ -2287,11 +2287,15 @@
void LCodeGen::DoCmpObjectEqAndBranch(LCmpObjectEqAndBranch* instr) {
Register left = ToRegister(instr->left());
- Operand right = ToOperand(instr->right());
int false_block = chunk_->LookupDestination(instr->false_block_id());
int true_block = chunk_->LookupDestination(instr->true_block_id());
- __ cmp(left, Operand(right));
+ if (instr->right()->IsConstantOperand()) {
+ __ cmp(left, ToHandle(LConstantOperand::cast(instr->right())));
+ } else {
+ Operand right = ToOperand(instr->right());
+ __ cmp(left, Operand(right));
+ }
EmitBranch(true_block, false_block, equal);
}
=======================================
--- /branches/bleeding_edge/src/ia32/lithium-ia32.cc Thu Apr 11 06:27:06
2013
+++ /branches/bleeding_edge/src/ia32/lithium-ia32.cc Thu Apr 18 02:53:49
2013
@@ -1693,7 +1693,7 @@
LInstruction* LChunkBuilder::DoCompareObjectEqAndBranch(
HCompareObjectEqAndBranch* instr) {
LOperand* left = UseRegisterAtStart(instr->left());
- LOperand* right = UseAtStart(instr->right());
+ LOperand* right = UseOrConstantAtStart(instr->right());
return new(zone()) LCmpObjectEqAndBranch(left, right);
}
=======================================
--- /branches/bleeding_edge/src/x64/lithium-codegen-x64.cc Tue Apr 16
05:30:51 2013
+++ /branches/bleeding_edge/src/x64/lithium-codegen-x64.cc Thu Apr 18
02:53:49 2013
@@ -2055,11 +2055,14 @@
void LCodeGen::DoCmpObjectEqAndBranch(LCmpObjectEqAndBranch* instr) {
Register left = ToRegister(instr->left());
- Register right = ToRegister(instr->right());
int false_block = chunk_->LookupDestination(instr->false_block_id());
int true_block = chunk_->LookupDestination(instr->true_block_id());
- __ cmpq(left, right);
+ if (instr->right()->IsConstantOperand()) {
+ __ Cmp(left, ToHandle(LConstantOperand::cast(instr->right())));
+ } else {
+ __ cmpq(left, ToRegister(instr->right()));
+ }
EmitBranch(true_block, false_block, equal);
}
=======================================
--- /branches/bleeding_edge/src/x64/lithium-x64.cc Thu Apr 11 06:27:06 2013
+++ /branches/bleeding_edge/src/x64/lithium-x64.cc Thu Apr 18 02:53:49 2013
@@ -1610,7 +1610,7 @@
LInstruction* LChunkBuilder::DoCompareObjectEqAndBranch(
HCompareObjectEqAndBranch* instr) {
LOperand* left = UseRegisterAtStart(instr->left());
- LOperand* right = UseRegisterAtStart(instr->right());
+ LOperand* right = UseRegisterOrConstantAtStart(instr->right());
return new(zone()) LCmpObjectEqAndBranch(left, right);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
