lgtm with comments
https://codereview.chromium.org/14022011/diff/2001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/14022011/diff/2001/src/ia32/lithium-codegen-ia32.cc#newcode4485
src/ia32/lithium-codegen-ia32.cc:4485: __ mov(operand,
Immediate(const_value));
Shouldn't you store as a SMI?
https://codereview.chromium.org/14022011/diff/2001/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/14022011/diff/2001/src/ia32/lithium-ia32.cc#newcode2422
src/ia32/lithium-ia32.cc:2422: val = UseRegister(instr->value());
Can't you just move this to the else of the above clause?
https://codereview.chromium.org/14022011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
