Revision: 14344
Author: [email protected]
Date: Thu Apr 18 16:47:40 2013
Log: MIPS: HArgument instructions currently require a frame. In
Lithium we can ensure a frame is created for these instructions via a
compile info flag.
Port r14339 (7d544be1)
BUG=
Review URL: https://codereview.chromium.org/14367003
http://code.google.com/p/v8/source/detail?r=14344
Modified:
/branches/bleeding_edge/src/mips/lithium-codegen-mips.h
/branches/bleeding_edge/src/mips/lithium-mips.cc
=======================================
--- /branches/bleeding_edge/src/mips/lithium-codegen-mips.h Thu Apr 18
06:45:19 2013
+++ /branches/bleeding_edge/src/mips/lithium-codegen-mips.h Thu Apr 18
16:47:40 2013
@@ -82,7 +82,8 @@
bool NeedsEagerFrame() const {
return GetStackSlotCount() > 0 ||
info()->is_non_deferred_calling() ||
- !info()->IsStub();
+ !info()->IsStub() ||
+ info()->requires_frame();
}
bool NeedsDeferredFrame() const {
return !NeedsEagerFrame() && info()->is_deferred_calling();
=======================================
--- /branches/bleeding_edge/src/mips/lithium-mips.cc Thu Apr 18 16:46:37
2013
+++ /branches/bleeding_edge/src/mips/lithium-mips.cc Thu Apr 18 16:47:40
2013
@@ -988,12 +988,14 @@
LInstruction* LChunkBuilder::DoArgumentsLength(HArgumentsLength* length) {
+ info()->MarkAsRequiresFrame();
return DefineAsRegister(
new(zone()) LArgumentsLength(UseRegister(length->value())));
}
LInstruction* LChunkBuilder::DoArgumentsElements(HArgumentsElements*
elems) {
+ info()->MarkAsRequiresFrame();
return DefineAsRegister(new(zone()) LArgumentsElements);
}
@@ -2331,6 +2333,7 @@
LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt*
instr) {
+ info()->MarkAsRequiresFrame();
LOperand* args = UseRegister(instr->arguments());
LOperand* length = UseTempRegister(instr->length());
LOperand* index = UseRegister(instr->index());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
