[+danno, since this is "Fix bugs in IfBuilder and improve functionality"]

Thanks for the report. Looks like those variables could simply be removed.

Interestingly, the Mac builders on our waterfall are happy with the change.
Probably it's only very recent clang versions that complain about it.


On Fri, Apr 19, 2013 at 11:09 AM, <[email protected]> wrote:

> Below a git diff that allows the build to succeed.  Maybe a compile guard
> could be added until the fields are used?
>
> $ git diff
> diff --git a/src/hydrogen.cc b/src/hydrogen.cc
> index e527057..ce0a0b4 100644
> --- a/src/hydrogen.cc
> +++ b/src/hydrogen.cc
> @@ -714,8 +714,8 @@ HGraphBuilder::IfBuilder::IfBuilder(HGraphBuilder*
> builder, int positi
>        finished_(false),
>        did_then_(false),
>        did_else_(false),
> -      deopt_then_(false),
> -      deopt_else_(false),
> +//      deopt_then_(false),
> +//      deopt_else_(false),
>        did_and_(false),
>        did_or_(false),
>        captured_(false),
> @@ -736,8 +736,8 @@ HGraphBuilder::IfBuilder::IfBuilder(
>        finished_(false),
>        did_then_(false),
>        did_else_(false),
> -      deopt_then_(false),
> -      deopt_else_(false),
> +//      deopt_then_(false),
> +//      deopt_else_(false),
>        did_and_(false),
>        did_or_(false),
>
> --
> --
> v8-dev mailing list
> [email protected]
> http://groups.google.com/group/v8-dev
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to