generally looks ok, but a comment and question.
https://codereview.chromium.org/14362023/diff/8001/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/14362023/diff/8001/src/assembler.cc#newcode1510
src/assembler.cc:1510: return OS::nan_value();
Please put {} around the return.
https://codereview.chromium.org/14362023/diff/8001/src/conversions.cc
File src/conversions.cc (right):
https://codereview.chromium.org/14362023/diff/8001/src/conversions.cc#newcode39
src/conversions.cc:39: using std::fpclassify;
Did you actually test this?
https://codereview.chromium.org/14362023/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
