On 2013/04/22 11:22:19, Yang wrote:
https://codereview.chromium.org/14404005/diff/2001/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/14404005/diff/2001/src/d8.cc#newcode299
src/d8.cc:299: for (int i = 0; i < data_->realm_count_; ++i)
Style guide wants brackets to accompany line breaks.
https://codereview.chromium.org/14404005/diff/2001/src/d8.cc#newcode302
src/d8.cc:302: if (!data_->realm_shared_.IsEmpty())
Ditto.
LGTM with previously mentioned nits.
https://codereview.chromium.org/14404005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
