LGTM with one nit. I will land this when the nits are addressed.
https://codereview.chromium.org/14075012/diff/4002/src/extensions/gc-extension.cc
File src/extensions/gc-extension.cc (right):
https://codereview.chromium.org/14075012/diff/4002/src/extensions/gc-extension.cc#newcode33
src/extensions/gc-extension.cc:33: const char* const
GCExtension::kSource = "native function gc();";
This constant it no longer needed, let's drop it.
https://codereview.chromium.org/14075012/diff/4002/src/extensions/gc-extension.h
File src/extensions/gc-extension.h (right):
https://codereview.chromium.org/14075012/diff/4002/src/extensions/gc-extension.h#newcode44
src/extensions/gc-extension.h:44: static const char* const kSource;
This constant it no longer needed, let's drop it.
https://codereview.chromium.org/14075012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
