Reviewers: Jakob,
Message:
PTAL. Deleting more stuff is always good. :)
https://codereview.chromium.org/14404012/diff/1/src/version.cc
File src/version.cc (right):
https://codereview.chromium.org/14404012/diff/1/src/version.cc#newcode43
src/version.cc:43: // Define SONAME to have the build system put a
specific SONAME into the
On 2013/04/22 17:30:15, Jakob wrote:
Actually, I don't think SONAME is used by anything anymore (except
cctest/test-version). Feel free to remove it (and
Version::GetSONAME(...)
below.)
Or you can leave it in for now, it doesn't hurt.
I am inclined to leave it in for now.
https://codereview.chromium.org/14404012/diff/1/tools/utils.py
File tools/utils.py (right):
https://codereview.chromium.org/14404012/diff/1/tools/utils.py#newcode71
tools/utils.py:71: # of running the 64 bit VM. Use the
v8_target_arch=x64 GYP define to force it
On 2013/04/22 17:30:15, Jakob wrote:
This entire file (utils.py) isn't used anymore. Looks like I forgot to
remove it
when I deleted test.py.
If you use this opportunity to delete it, please update
tools/test-server.py by
deleting lines 127 through 134 in there.
Done.
Description:
Change deprecated comments that still talk about SCons.
[email protected]
Please review this at https://codereview.chromium.org/14404012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/version.cc
M tools/check-static-initializers.sh
M tools/js2c.py
M tools/test-server.py
M tools/utils.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
