Reviewers: Yang,
Message:
Please take a look
Description:
Adds EXTERNAL_DOUBLE_ARRAY to a list of instance types
BUG=v8:2646
Please review this at https://codereview.chromium.org/14042008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/objects.h
A + test/mjsunit/regress/regress-2646.js
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
0e64e37eb1988b92e87404d5c738b6a55ac7fff7..8de3c690e51bb2714955fee6386a4796c2a2aa88
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -366,6 +366,7 @@ const int kStubMinorKeyBits = kBitsPerInt - kSmiTagSize
- kStubMajorKeyBits;
V(EXTERNAL_INT_ARRAY_TYPE)
\
V(EXTERNAL_UNSIGNED_INT_ARRAY_TYPE)
\
V(EXTERNAL_FLOAT_ARRAY_TYPE)
\
+
V(EXTERNAL_DOUBLE_ARRAY_TYPE)
\
V(EXTERNAL_PIXEL_ARRAY_TYPE)
\
V(FILLER_TYPE)
\
\
Index: test/mjsunit/regress/regress-2646.js
diff --git a/test/mjsunit/regress/regress-crbug-217858.js
b/test/mjsunit/regress/regress-2646.js
similarity index 86%
copy from test/mjsunit/regress/regress-crbug-217858.js
copy to test/mjsunit/regress/regress-2646.js
index
8563e07eee9e1acbcdc8c5c28c461f2d27fad6f1..c51a28060ca19b073693bb3f575b45033dd7b73c
100644
--- a/test/mjsunit/regress/regress-crbug-217858.js
+++ b/test/mjsunit/regress/regress-2646.js
@@ -25,16 +25,13 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// Flags: --allow-natives-syntax
+// Flags: --heap-stats
-var r = /r/;
-var a = "";
-function f() {
- %OptimizeFunctionOnNextCall(f, "osr");
- for (var i = 0; i < 1000000; i++) {
- a += i.toString();
- r[r] = function() {};
- }
-}
+var expectedItemsCount = 10000,
+ itemSize = 5,
+ heap = new ArrayBuffer(expectedItemsCount * itemSize * 8),
+ storage = [];
-f();
+for (var i = 0; i < expectedItemsCount; i++) {
+ storage.push(new Float64Array(heap, 0, itemSize));
+}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
