DBC.
https://codereview.chromium.org/14211009/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/14211009/diff/1/src/hydrogen.cc#newcode10052
src/hydrogen.cc:10052:
compare->set_observed_input_representation(Representation::Integer32(),
Manually setting observed input representations is a hack. Please
harvest i's representation from the >>> operation instead.
https://codereview.chromium.org/14211009/diff/1/src/hydrogen.cc#newcode10090
src/hydrogen.cc:10090: if (!right->representation().IsInteger32())
return false;
You can't rely on representations at graph construction time. For most
instructions, they're not set at all, and they can change later during
the representation inference phase.
I think replacement operations like this belong in the Canonicalization
pass.
https://codereview.chromium.org/14211009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
