Reviewers: Michael Starzinger,
Message:
PTAL.
Description:
Properly consider Double inputs for representation inference when they are
not
marked as kFlexibleRepresentation
Please review this at https://codereview.chromium.org/14408006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.cc
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index
691620921a94e0ca723b151655a82c391b5dfd96..11e014e3c5427195deea917d70374865edd8f1b0
100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -2249,11 +2249,11 @@ Representation
HBinaryOperation::RepresentationFromInputs() {
Representation right_rep = right()->representation();
if (left_rep.is_more_general_than(rep) &&
- left()->CheckFlag(kFlexibleRepresentation)) {
+ !left_rep.IsTagged()) {
rep = left_rep;
}
if (right_rep.is_more_general_than(rep) &&
- right()->CheckFlag(kFlexibleRepresentation)) {
+ !right_rep.IsTagged()) {
rep = right_rep;
}
// Consider observed output representation, but ignore it if it's Double,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
