Hi Yang, just a couple comment issues. Then lgtm.
Thanks!
--Michael
https://chromiumcodereview.appspot.com/13940014/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):
https://chromiumcodereview.appspot.com/13940014/diff/1/src/x64/assembler-x64.h#newcode204
src/x64/assembler-x64.h:204: // Windows calling convention
Can you mention fastcall here?
https://chromiumcodereview.appspot.com/13940014/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://chromiumcodereview.appspot.com/13940014/diff/1/src/x64/code-stubs-x64.cc#newcode3010
src/x64/code-stubs-x64.cc:3010: // rbx: previous index
These comments should be updated to refer to arg_reg_*.
https://chromiumcodereview.appspot.com/13940014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
