Reviewers: Michael Starzinger,
Description:
MathSqrt and MathPowHalf do not cause any promotion.
Please review this at https://codereview.chromium.org/13829009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index
6ec698179a9b7d7ed797e447297d60d8019084f4..7cba2a339927247ae991dc68ba7be889a5801a30
100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -2609,18 +2609,21 @@ class HUnaryMathOperation: public
HTemplateInstruction<2> {
case kMathAbs:
// Not setting representation here: it is None intentionally.
SetFlag(kFlexibleRepresentation);
+ // TODO(svenpanne) This flag is actually only needed if
representation()
+ // is tagged, and not when it is an unboxed double or unboxed
integer.
SetGVNFlag(kChangesNewSpacePromotion);
break;
- case kMathSqrt:
- case kMathPowHalf:
case kMathLog:
case kMathSin:
case kMathCos:
case kMathTan:
set_representation(Representation::Double());
+ // These operations use the TranscendentalCache, so they may
allocate.
SetGVNFlag(kChangesNewSpacePromotion);
break;
case kMathExp:
+ case kMathSqrt:
+ case kMathPowHalf:
set_representation(Representation::Double());
break;
default:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
