Revision: 14414
Author: [email protected]
Date: Wed Apr 24 05:43:33 2013
Log: MathSqrt and MathPowHalf do not cause any promotion.
Review URL: https://codereview.chromium.org/13829009
http://code.google.com/p/v8/source/detail?r=14414
Modified:
/branches/bleeding_edge/src/hydrogen-instructions.h
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.h Wed Apr 24 04:32:17
2013
+++ /branches/bleeding_edge/src/hydrogen-instructions.h Wed Apr 24 05:43:33
2013
@@ -2609,18 +2609,21 @@
case kMathAbs:
// Not setting representation here: it is None intentionally.
SetFlag(kFlexibleRepresentation);
+ // TODO(svenpanne) This flag is actually only needed if
representation()
+ // is tagged, and not when it is an unboxed double or unboxed
integer.
SetGVNFlag(kChangesNewSpacePromotion);
break;
- case kMathSqrt:
- case kMathPowHalf:
case kMathLog:
case kMathSin:
case kMathCos:
case kMathTan:
set_representation(Representation::Double());
+ // These operations use the TranscendentalCache, so they may
allocate.
SetGVNFlag(kChangesNewSpacePromotion);
break;
case kMathExp:
+ case kMathSqrt:
+ case kMathPowHalf:
set_representation(Representation::Double());
break;
default:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
