LGTM with a nit, too.
https://codereview.chromium.org/14150017/diff/3001/test/cctest/test-lockers.cc
File test/cctest/test-lockers.cc (right):
https://codereview.chromium.org/14150017/diff/3001/test/cctest/test-lockers.cc#newcode501
test/cctest/test-lockers.cc:501: thread;
On 2013/04/24 13:15:16, jochen wrote:
On 2013/04/24 13:13:38, dcarney wrote:
> spacing
that's the way the google c++ style wants it (since it's the type not
fitting on
the one line)
Perhaps we can resolve this dispute by using i::SmartPointer? :-)
https://codereview.chromium.org/14150017/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
