Reviewers: Sven Panne, Message: On 2013/04/24 14:03:41, Sven Panne wrote:
https://codereview.chromium.org/14139033/diff/1/src/vm-state-inl.h File src/vm-state-inl.h (right):
https://codereview.chromium.org/14139033/diff/1/src/vm-state-inl.h#newcode64src/vm-state-inl.h:64: if (FLAG_log_timer_events && previous_tag_ != EXTERNAL
&&
Tag == EXTERNAL) {
Do we really don't want to call set_current_vm_state for EXTERNAL? If yes,
template specialization (for EXTERNAL) makes things a bit clearer here.
Thanks for catching this mistake! Fixed in the new patch set. Description: Clean up VMState a little bit. [email protected] BUG= Please review this at https://codereview.chromium.org/14139033/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/api.cc M src/arm/macro-assembler-arm.cc M src/builtins.cc M src/compiler.cc M src/execution.cc M src/flag-definitions.h M src/global-handles.cc M src/handles.cc M src/heap.cc M src/ia32/macro-assembler-ia32.cc M src/isolate.h M src/isolate.cc M src/log-utils.h M src/log-utils.cc M src/log.h M src/log.cc M src/objects.cc M src/profile-generator-inl.h M src/runtime.cc M src/stub-cache.cc M src/v8globals.h M src/vm-state-inl.h M src/vm-state.h M src/x64/macro-assembler-x64.cc M tools/tickprocessor.js -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
