Reviewers: Yang,
Message:
This fixes a GCMole evaluation order warning. The warning is actually a
false
positive because GCMole isn't smart enough to figure out that ...
a) hidden_stack_trace_string is an immovable value
b) GetHiddenProperty cannot cause a GC in this case
Since this code is currently deactivated anyways, this is a quick fix to
make
the warning go away.
Description:
Prevent false positive from GCMole in DeferredFormatStackTrace.
[email protected]
TEST=gcmole
Please review this at https://codereview.chromium.org/14416010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/heap.cc
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index
a1e2a48c0576afa7c86751fe327b9f3d550ecc8c..fbff7451a264e099d1f41d2c88e38873d3e780f4
100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -7696,7 +7696,8 @@ void
ErrorObjectList::DeferredFormatStackTrace(Isolate* isolate) {
if (!getter_obj->IsJSFunction()) continue;
getter_fun = JSFunction::cast(getter_obj);
String* key = isolate->heap()->hidden_stack_trace_string();
- if (key != getter_fun->GetHiddenProperty(key)) continue;
+ Object* value = getter_fun->GetHiddenProperty(key);
+ if (key != value) continue;
}
budget--;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
