Status: New
Owner: ----
New issue 2658 by [email protected]: Eliminate dependency on cygwin for
Windows build (patch included)
http://code.google.com/p/v8/issues/detail?id=2658
The only reason the build for Windows requires cygwin at this point is to
properly execute the actions involving js2c.py. The reason that cygwin is
required for this stems from a defect in the msvs generator within gyp and
how it constructs command lines. The defect is that anything not viewed as
a switch (that is, anything not beginning with "-" or "/") is viewed
instead as a file name and is has its directory path rewritten. This is
fine for file arguments, but is not fine for positional arguments that are
not file names.
The attached patch works around this gyp defect by changing the command
line syntax for js2c. It changes the two non-file arguments from positional
syntax to optional syntax with argparse. It adds specifications for
argument "--type" and "--compression" so that the command lines can be
constructed as, for example, "--type=CORE", which avoids the gyp defect.
The only other thing that needs to be done (it's not in the patch set) is
to turn off generation of cygwin command lines by setting
attribute "'mvsv_cygwin_shell': 0" in default_targets.
Attachments:
change_js2c_arguments.diff 2.7 KB
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
