LGTM with nits
https://chromiumcodereview.appspot.com/14137026/diff/1/include/v8.h
File include/v8.h (right):
https://chromiumcodereview.appspot.com/14137026/diff/1/include/v8.h#newcode95
include/v8.h:95: #ifdef __GNUC__
An undefined preprocessor symbol evaluates to 0 by definition, so you
can totally remove this #ifdef and its #else branch.
https://chromiumcodereview.appspot.com/14137026/diff/1/include/v8.h#newcode97
include/v8.h:97: #define V8_UNLIKELY(x) __builtin_expect(!!(x), 0)
According to http://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html you
don't need the !! here and below.
https://chromiumcodereview.appspot.com/14137026/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
