Revision: 14449
Author:   [email protected]
Date:     Fri Apr 26 01:49:20 2013
Log: Fix test/build failures (win64 compile warning, isolate test parallel compilation failure, gcmole issue, isolate test intermittant failure)

BUG=

Review URL: https://codereview.chromium.org/14265024
http://code.google.com/p/v8/source/detail?r=14449

Modified:
 /branches/bleeding_edge/src/bootstrapper.cc
 /branches/bleeding_edge/src/heap.cc
 /branches/bleeding_edge/src/hydrogen.cc

=======================================
--- /branches/bleeding_edge/src/bootstrapper.cc Thu Apr 25 09:00:32 2013
+++ /branches/bleeding_edge/src/bootstrapper.cc Fri Apr 26 01:49:20 2013
@@ -890,15 +890,15 @@
     // overwritten by JS code.
     native_context()->set_array_function(*array_function);

-    // Cache the array maps
-    MaybeObject* cache_result = CacheInitialJSArrayMaps(*native_context(),
-                                                        *initial_map);
-    if (cache_result->IsFailure()) return false;
-
     if (FLAG_optimize_constructed_arrays) {
+      // Cache the array maps, needed by ArrayConstructorStub
+ MaybeObject* cache_result = CacheInitialJSArrayMaps(*native_context(),
+                                                          *initial_map);
+      if (cache_result->IsFailure()) return false;
+
       ArrayConstructorStub array_constructor_stub(isolate);
-      array_function->shared()->set_construct_stub(
-          *array_constructor_stub.GetCode(isolate));
+      Handle<Code> code = array_constructor_stub.GetCode(isolate);
+      array_function->shared()->set_construct_stub(*code);
     } else {
       array_function->shared()->set_construct_stub(
isolate->builtins()->builtin(Builtins::kCommonArrayConstructCode));
=======================================
--- /branches/bleeding_edge/src/heap.cc Fri Apr 26 01:12:21 2013
+++ /branches/bleeding_edge/src/heap.cc Fri Apr 26 01:49:20 2013
@@ -163,7 +163,8 @@
 #endif
       promotion_queue_(this),
       configured_(false),
-      chunks_queued_for_free_(NULL) {
+      chunks_queued_for_free_(NULL),
+      relocation_mutex_(NULL) {
   // Allow build-time customization of the max semispace size. Building
   // V8 with snapshots and a non-default max semispace size is much
   // easier if you can define it as part of the build environment.
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc     Fri Apr 26 01:47:02 2013
+++ /branches/bleeding_edge/src/hydrogen.cc     Fri Apr 26 01:49:20 2013
@@ -1860,7 +1860,7 @@
       HGlobalObject(context));
   HInstruction* native_context = AddInstruction(new(zone())
HLoadNamedField(global_object, true, GlobalObject::kNativeContextOffset));
-  size_t offset = Context::kHeaderSize +
+  int offset = Context::kHeaderSize +
       kPointerSize * Context::JS_ARRAY_MAPS_INDEX;
   HInstruction* map_array = AddInstruction(new(zone())
       HLoadNamedField(native_context, true, offset));

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to