Reviewers: danno, Jakob,
Description:
Revert "frames.h/cc cleanup"
This reverts r14496 which broke tests in debug mode:
Command:
/mnt/data/b/build/slave/v8-linux-nosnap-debug/build/v8/out/Debug/cctest
test-log/LogAccessorCallbacks --nobreak-on-abort --nodead-code-elimination
--nofold-constants --enable-slow-asserts --debug-code --verify-heap
--testing_serialization_file=/mnt/data/b/build/slave/v8-linux-nosnap-debug/build/v8/out/.serdes/serdes_LogAccessorCallbacks
=== cctest/test-log/LogCallbacks ===
--- stderr ---
TBR=danno
BUG=None
Please review this at https://codereview.chromium.org/14651004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
src/frames.h
src/frames.cc
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index
a389df4b5570258745facc99619247f5c8ad3f42..aaf8c79e23256a12d4d3a7fe7bce939f9f604ff8
100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -168,6 +168,7 @@ void StackFrameIterator::Reset() {
reinterpret_cast<Address*>(StandardFrame::ComputePCAddress(fp_)));
type = StackFrame::ComputeType(isolate(), &state);
}
+ if (SingletonFor(type) == NULL) return;
frame_ = SingletonFor(type, &state);
}
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index
30ccf388f8b9032bb0bc1c085cde4be2bc3fd666..678191b950a0172a37f62a78fb9533f977502613
100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -969,11 +969,9 @@ typedef
JavaScriptFrameIteratorTemp<SafeStackFrameIterator>
class SafeStackTraceFrameIterator: public SafeJavaScriptFrameIterator {
public:
- SafeStackTraceFrameIterator(Isolate* isolate,
- Address fp,
- Address sp,
- Address low_bound,
- Address high_bound);
+ explicit SafeStackTraceFrameIterator(Isolate* isolate,
+ Address fp, Address sp,
+ Address low_bound, Address
high_bound);
void Advance();
};
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
