Revision: 14502
Author: [email protected]
Date: Tue Apr 30 09:51:30 2013
Log: Revert "frames.h/cc cleanup"
This reverts r14496 which broke tests in debug mode:
Command:
/mnt/data/b/build/slave/v8-linux-nosnap-debug/build/v8/out/Debug/cctest
test-log/LogAccessorCallbacks --nobreak-on-abort --nodead-code-elimination
--nofold-constants --enable-slow-asserts --debug-code --verify-heap
--testing_serialization_file=/mnt/data/b/build/slave/v8-linux-nosnap-debug/build/v8/out/.serdes/serdes_LogAccessorCallbacks
=== cctest/test-log/LogCallbacks ===
--- stderr ---
[email protected]
BUG=None
Review URL: https://codereview.chromium.org/14651004
http://code.google.com/p/v8/source/detail?r=14502
Modified:
/branches/bleeding_edge/src/frames.cc
/branches/bleeding_edge/src/frames.h
=======================================
--- /branches/bleeding_edge/src/frames.cc Tue Apr 30 07:37:18 2013
+++ /branches/bleeding_edge/src/frames.cc Tue Apr 30 09:51:30 2013
@@ -168,6 +168,7 @@
reinterpret_cast<Address*>(StandardFrame::ComputePCAddress(fp_)));
type = StackFrame::ComputeType(isolate(), &state);
}
+ if (SingletonFor(type) == NULL) return;
frame_ = SingletonFor(type, &state);
}
=======================================
--- /branches/bleeding_edge/src/frames.h Tue Apr 30 07:37:18 2013
+++ /branches/bleeding_edge/src/frames.h Tue Apr 30 09:51:30 2013
@@ -969,11 +969,9 @@
class SafeStackTraceFrameIterator: public SafeJavaScriptFrameIterator {
public:
- SafeStackTraceFrameIterator(Isolate* isolate,
- Address fp,
- Address sp,
- Address low_bound,
- Address high_bound);
+ explicit SafeStackTraceFrameIterator(Isolate* isolate,
+ Address fp, Address sp,
+ Address low_bound, Address
high_bound);
void Advance();
};
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
