Thanks, the fixed patchset is uploaded.
https://codereview.chromium.org/14678006/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):
https://codereview.chromium.org/14678006/diff/1/src/mips/macro-assembler-mips.cc#newcode3144
src/mips/macro-assembler-mips.cc:3144: lw(scratch1, MemOperand(t0, 0));
On 2013/05/03 23:24:27, Paul Lind wrote:
t0 here should be scratch1. (currently, there is only one caller, and
t0 is
passed for scratch1, but if this function gets called differently in
the future,
it would be a bug.)
Hannes, this would be true for your original r14540 also, you might
want to look
at that.
Good catch, thanks! Fixed.
https://codereview.chromium.org/14678006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
