Looking good. First round of comments.
https://codereview.chromium.org/14846017/diff/2001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/14846017/diff/2001/src/builtins.cc#newcode235
src/builtins.cc:235: ASSERT(constructor->initial_map()->elements_kind()
== kind);
It seems more resilient to just use the initial map (and its elements
kind), and make that one holey when necessary. You can keep the ASSERT
just to find this place back when you make changes.
https://codereview.chromium.org/14846017/diff/2001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/14846017/diff/2001/src/code-stubs-hydrogen.cc#newcode545
src/code-stubs-hydrogen.cc:545: HValue* array_result = GetParameter(0);
Remove
https://codereview.chromium.org/14846017/diff/2001/src/code-stubs-hydrogen.cc#newcode557
src/code-stubs-hydrogen.cc:557: array_result =
array_builder.AllocateEmptyArray();
Just return.
https://codereview.chromium.org/14846017/diff/2001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/14846017/diff/2001/src/ia32/code-stubs-ia32.cc#newcode7925
src/ia32/code-stubs-ia32.cc:7925: __ mov(edx, FieldOperand(ebx,
kPointerSize));
Don't you want to use JSGlobalPropertyCell::kValueOffset here?
https://codereview.chromium.org/14846017/diff/2001/test/mjsunit/allocation-site-info.js
File test/mjsunit/allocation-site-info.js (right):
https://codereview.chromium.org/14846017/diff/2001/test/mjsunit/allocation-site-info.js#newcode300
test/mjsunit/allocation-site-info.js:300: assertTrue(new
realmBArray(1,2,3) instanceof realmBArray);
Please add another test that checks the optimized instantiate behavior.
https://codereview.chromium.org/14846017/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
