Thanks for having a look!
https://codereview.chromium.org/14788013/diff/4001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/14788013/diff/4001/include/v8.h#newcode5363
include/v8.h:5363: return;
On 2013/05/07 09:49:31, Sven Panne wrote:
Style nit: Put this on the previous line. Debatable, but usual v8
"style"...
I added "this->val_ = NULL" here, so this became a multi-line block :)
https://codereview.chromium.org/14788013/diff/4001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/14788013/diff/4001/test/cctest/test-api.cc#newcode2489
test/cctest/test-api.cc:2489: THREADED_TEST(ResettingGlobalHandle) {
On 2013/05/07 09:49:31, Sven Panne wrote:
A test for passing an empty handle to reset is missing. Either add
this test or
change the API, ASSERTing that it never happens. Don't know the call
sites, so I
can't decide...
Added a test here which says that after resetting to an empty handle,
the handle is empty.
https://codereview.chromium.org/14788013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
